Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about devhub/latest tag #636

Merged
merged 3 commits into from
Jul 21, 2022

Conversation

sacha-l
Copy link

@sacha-l sacha-l commented Dec 1, 2021

Adding a note about our internal process for keeping our node template, tutorial write-ups and solutions up-to-date.

Not exactly sure where this should live but this feels ok for now.

CC: @nukemandan: step 3. needs a little more details. Can you add your edits in please? Just commit directly to this PR 😎 .

@sacha-l sacha-l temporarily deployed to test December 1, 2021 14:32 Inactive
@sacha-l sacha-l temporarily deployed to test December 1, 2021 14:38 Inactive
Copy link
Contributor

@nuke-web3 nuke-web3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start! 😀

I think we should make these changes, and also describe the E2E testing required before anyone moves this tag. You make changes that make it into main on the templates, and only after testing do you move the latest tag. So the steps are in need of being tweaked.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
Co-authored-by: Dan Shields <35669742+NukeManDan@users.noreply.github.com>
@sacha-l sacha-l temporarily deployed to test December 7, 2021 13:26 Inactive
Copy link
Author

@sacha-l sacha-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review 😃

README.md Show resolved Hide resolved
@sacha-l sacha-l temporarily deployed to test December 7, 2021 13:26 Inactive
@sacha-l sacha-l temporarily deployed to test December 7, 2021 13:31 Inactive
This requires following a few steps for every new release of Substrate upstream:

1. Go to the [release tags in the Substrate repository](https://github.com/paritytech/substrate/tags).
1. Set the `devhub/latest` tag to the latest [Polkadot release](https://github.com/paritytech/polkadot/releases) (`polakdot-v<Major>.<Minor>.<Patch>`, not the release candidates apppended `...-rc#`).
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nukemandan : FYI we used Substrate's latest here.

@sacha-l
Copy link
Author

sacha-l commented Dec 15, 2021

Good start! 😀

I think we should make these changes, and also describe the E2E testing required before anyone moves this tag. You make changes that make it into main on the templates, and only after testing do you move the latest tag. So the steps are in need of being tweaked.

Do you have any other suggestions to address the E2E testing? Feel free to commit directly to this branch.

@sacha-l
Copy link
Author

sacha-l commented Jan 9, 2022

@nukemandan : ping ! :)

@sacha-l
Copy link
Author

sacha-l commented Mar 24, 2022

This can be closed I believe. We're no longer following this process anymore. @nukemandan can you find a reference PR or issue to add more context and close?

@lisa-parity
Copy link
Contributor

This seems to be obsolete with the other changes and this tag never made it into the core substrate repo, so I suggest closing this as clutter that won't be merged.

@sacha-l sacha-l merged commit 41aa442 into archive/main-mdx Jul 21, 2022
@sacha-l sacha-l deleted the sl/add-note-about-node-template branch July 21, 2022 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants