-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add note about devhub/latest tag #636
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start! 😀
I think we should make these changes, and also describe the E2E testing required before anyone moves this tag. You make changes that make it into main
on the templates, and only after testing do you move the latest tag. So the steps are in need of being tweaked.
Co-authored-by: Dan Shields <35669742+NukeManDan@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review 😃
This requires following a few steps for every new release of Substrate upstream: | ||
|
||
1. Go to the [release tags in the Substrate repository](https://github.com/paritytech/substrate/tags). | ||
1. Set the `devhub/latest` tag to the latest [Polkadot release](https://github.com/paritytech/polkadot/releases) (`polakdot-v<Major>.<Minor>.<Patch>`, not the release candidates apppended `...-rc#`). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nukemandan : FYI we used Substrate's latest here.
Do you have any other suggestions to address the E2E testing? Feel free to commit directly to this branch. |
@nukemandan : ping ! :) |
This can be closed I believe. We're no longer following this process anymore. @nukemandan can you find a reference PR or issue to add more context and close? |
This seems to be obsolete with the other changes and this tag never made it into the core substrate repo, so I suggest closing this as clutter that won't be merged. |
Adding a note about our internal process for keeping our node template, tutorial write-ups and solutions up-to-date.
Not exactly sure where this should live but this feels ok for now.
CC: @nukemandan: step 3. needs a little more details. Can you add your edits in please? Just commit directly to this PR 😎 .