Skip to content

Commit

Permalink
rename protos to align with conventions (#180)
Browse files Browse the repository at this point in the history
## What is this change?

Changes the names of our proto message fields to align with the style
guide.

## Why make this change?

We didn't get it right first pass:
https://protobuf.dev/programming-guides/style/
  • Loading branch information
brandonjbjelland committed Aug 11, 2023
1 parent d0e673b commit 09c0b48
Show file tree
Hide file tree
Showing 2 changed files with 52 additions and 52 deletions.
90 changes: 45 additions & 45 deletions internal/sci/sci.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 7 additions & 7 deletions internal/sci/sci.proto
Original file line number Diff line number Diff line change
Expand Up @@ -9,21 +9,21 @@ service Controller {
}

message CreateSignedURLRequest {
string bucketName = 1;
string objectName = 2;
int64 expirationSeconds = 3;
string md5checksum = 4;
string bucket_name = 1;
string object_name = 2;
int64 expiration_seconds = 3;
string md5_checksum = 4;
}

message CreateSignedURLResponse {
string url = 1;
}

message GetObjectMd5Request {
string bucketName = 1;
string objectName = 2;
string bucket_name = 1;
string object_name = 2;
}

message GetObjectMd5Response {
string md5checksum = 1;
string md5_checksum = 1;
}

0 comments on commit 09c0b48

Please sign in to comment.