set save_steps to 5 by default #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The HuggingFace transformer.TrainingArguments uses a default value of 500, however that doesn't make sense for our dataset which only uses 71 steps. So we should set a smaller save_steps value in our examples. This also helps with users understanding how to override specific parameters.
brandonjbjelland
previously approved these changes
Jul 31, 2023
Co-authored-by: Brandon J. Bjelland <brandon@atscale.run>
|
added your suggestion and will merge if CI passes |
brandonjbjelland
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HuggingFace transformer.TrainingArguments uses a default value of 500, however that doesn't make sense for our k8s dataset which only uses 71 steps. So we should set a smaller save_steps value in our examples.
This also helps with users understanding how to override specific parameters.