Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add live-syncing from notebook to local machine #162

Merged
merged 15 commits into from
Aug 3, 2023
Merged

Conversation

nstogner
Copy link
Contributor

@nstogner nstogner commented Aug 2, 2023

Fixes #140

TODO: Arch description and diagrams.

samos123
samos123 previously approved these changes Aug 2, 2023
@samos123
Copy link
Contributor

samos123 commented Aug 2, 2023

This scenario might cause a user to lose their local changes:

  1. In your local directory make some changes to the src/my-book.ipynb
  2. Create a notebook that uses a prebuilt image
  3. Use kubectl notebook to sync local directory

Assumption of what would happen, the notebook sync would sync the src/my-book.ipynb from the prebuilt image to my local directory. That would overwrite my local changes.

Workaround: Ensure only sync local directory can be used when building the image from local directory?

@nstogner
Copy link
Contributor Author

nstogner commented Aug 2, 2023

@samos123 Agreed, that scenario could be an issue. A tricky one to figure out a solution for, but a good one to keep noodling on.

@samos123
Copy link
Contributor

samos123 commented Aug 2, 2023

I don't think that scenario should block this PR. I can file a separate issue for tackling that scenario.

@nstogner
Copy link
Contributor Author

nstogner commented Aug 3, 2023

NOTE: updates to goreleaser end up churning out a release that looks like: https://github.com/substratusai/substratus/releases/tag/v0.0.99

@samos123 samos123 changed the title WIP: Add live-syncing from notebook to local machine Add live-syncing from notebook to local machine Aug 3, 2023
Copy link
Contributor

@brandonjbjelland brandonjbjelland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@samos123 samos123 merged commit ddd3606 into main Aug 3, 2023
4 checks passed
@samos123 samos123 deleted the nb-live-sync branch August 3, 2023 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Notebook support constant file sync
3 participants