Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Hanging Notebooks #175

Merged
merged 3 commits into from
Aug 9, 2023
Merged

Fix Hanging Notebooks #175

merged 3 commits into from
Aug 9, 2023

Conversation

nstogner
Copy link
Contributor

@nstogner nstogner commented Aug 9, 2023 •
edited

Fixes #173

  • Propagate context through all long-running operations.
  • Ensure context is cancelled when either of the 2 primary go-routines exit (for syncing or port-forwarding).
  • Move tar-balling to after notebook file check (I found that I would accidentally execute k notebook -d . on the root of the repo and it would take a long time to tar and then fail after it cant find the notebook.yaml file).
  • Add some context-related logging.

Fixes #174

  • Ignore syncing of all dot-files.

Misc

  • Add exponential backoff to port-forward retries (currently max 3 retries).

@nstogner nstogner requested a review from samos123 August 9, 2023 10:49
brandonjbjelland
brandonjbjelland reviewed Aug 9, 2023
View reviewed changes
kubectl/internal/commands/notebook_test.go
@@ -25,7 +25,7 @@ func TestNotebook(t *testing.T) {
"--build", "./test-notebook",
"--kubeconfig", kubectlKubeconfigPath,
"--no-open-browser",
//"-v=9",
"-v=4",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logging verbosity, ya?

brandonjbjelland
brandonjbjelland approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@brandonjbjelland brandonjbjelland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥑

@nstogner nstogner merged commit bfa2e99 into main Aug 9, 2023
4 checks passed
@nstogner nstogner deleted the fix-nb-hang branch August 9, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandonjbjelland brandonjbjelland brandonjbjelland approved these changes

@samos123 samos123 Awaiting requested review from samos123

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@nstogner @brandonjbjelland