-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding proto definitions for KSA <=> IAM actions in SCI #177
Merged
brandonjbjelland
merged 6 commits into
main
from
feat/add-proto-definitions-for-BindKSA
Aug 11, 2023
Merged
adding proto definitions for KSA <=> IAM actions in SCI #177
brandonjbjelland
merged 6 commits into
main
from
feat/add-proto-definitions-for-BindKSA
Aug 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonjbjelland
force-pushed
the
feat/add-proto-definitions-for-BindKSA
branch
from
August 10, 2023 08:00
759ac51
to
202d084
Compare
nstogner
requested changes
Aug 10, 2023
brandonjbjelland
force-pushed
the
feat/add-proto-definitions-for-BindKSA
branch
2 times, most recently
from
August 10, 2023 21:17
d86dd68
to
a6a6a1f
Compare
brandonjbjelland
changed the title
adding proto definitions for BindKSAToIAMPrincipal
adding proto definitions for KSA <=>IAM actions in SCI
Aug 10, 2023
brandonjbjelland
changed the title
adding proto definitions for KSA <=>IAM actions in SCI
adding proto definitions for KSA <=> IAM actions in SCI
Aug 10, 2023
brandonjbjelland
force-pushed
the
feat/add-proto-definitions-for-BindKSA
branch
from
August 10, 2023 21:20
a6a6a1f
to
4fefb3e
Compare
brandonjbjelland
force-pushed
the
feat/add-proto-definitions-for-BindKSA
branch
from
August 10, 2023 21:30
4fefb3e
to
6588737
Compare
Related: #180 |
samos123
requested changes
Aug 10, 2023
samos123
previously approved these changes
Aug 11, 2023
nstogner
previously approved these changes
Aug 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
brandonjbjelland
dismissed stale reviews from nstogner and samos123
via
August 11, 2023 05:43
fa145d5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change?
Adds protobuf definitions and messages for the new service
Why make this change?
As a part of #171