Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding proto definitions for KSA <=> IAM actions in SCI #177

Merged
merged 6 commits into from
Aug 11, 2023

Conversation

brandonjbjelland
Copy link
Contributor

@brandonjbjelland brandonjbjelland commented Aug 10, 2023

What is this change?

Adds protobuf definitions and messages for the new service

Why make this change?

As a part of #171

@brandonjbjelland brandonjbjelland force-pushed the feat/add-proto-definitions-for-BindKSA branch from 759ac51 to 202d084 Compare August 10, 2023 08:00
internal/sci/sci.proto Outdated Show resolved Hide resolved
internal/sci/sci.proto Outdated Show resolved Hide resolved
internal/sci/sci.proto Outdated Show resolved Hide resolved
internal/sci/sci.proto Outdated Show resolved Hide resolved
internal/sci/sci.proto Outdated Show resolved Hide resolved
@brandonjbjelland brandonjbjelland force-pushed the feat/add-proto-definitions-for-BindKSA branch 2 times, most recently from d86dd68 to a6a6a1f Compare August 10, 2023 21:17
@brandonjbjelland brandonjbjelland changed the title adding proto definitions for BindKSAToIAMPrincipal adding proto definitions for KSA <=>IAM actions in SCI Aug 10, 2023
@brandonjbjelland brandonjbjelland changed the title adding proto definitions for KSA <=>IAM actions in SCI adding proto definitions for KSA <=> IAM actions in SCI Aug 10, 2023
@brandonjbjelland brandonjbjelland force-pushed the feat/add-proto-definitions-for-BindKSA branch from a6a6a1f to 4fefb3e Compare August 10, 2023 21:20
@brandonjbjelland brandonjbjelland force-pushed the feat/add-proto-definitions-for-BindKSA branch from 4fefb3e to 6588737 Compare August 10, 2023 21:30
@brandonjbjelland
Copy link
Contributor Author

Related: #180

internal/sci/sci.proto Outdated Show resolved Hide resolved
samos123
samos123 previously approved these changes Aug 11, 2023
nstogner
nstogner previously approved these changes Aug 11, 2023
Copy link
Contributor

@nstogner nstogner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@brandonjbjelland brandonjbjelland merged commit 2df1eca into main Aug 11, 2023
4 checks passed
@brandonjbjelland brandonjbjelland deleted the feat/add-proto-definitions-for-BindKSA branch August 11, 2023 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants