-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GCP: Updated install flow and managed infra #185
Conversation
34c1935
to
519f445
Compare
504ae13
to
ad7bc70
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove config/sci-kind
and config/install-kind
? These will cause merge conflicts later. Other than that, I dont see blockers to merge.
install/scripts/gcp-up.sh
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I expected to see a companion gcp-down.sh
. What, do you work for Google or something? 😛
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh right I hadn't gotten to it. Good catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is fully working, awesome work and ship it when you're ready.
e2fb7b5
to
0847ad9
Compare
This reverts commit c0b97de.
0ff5018
to
23cf34d
Compare
b316d56
to
85eb2e9
Compare
603a0f2
to
29af713
Compare
The GCP branch is working very good so far. Here is what I tested:
make dev-run-gcp and verifying workload identity things got installed
Issue has been resolved by retrying and sleeping for 5 seconds during initial startup of sci-gcp. There was a long delay after annotating the K8s SA for it to be able to utilize the GSA. As a result the sci-gcp container will restart many times until GKE workload identity finally starts working. You would originally see the following error message:
Issue: Kaniko builder gets stuck when creating a new namespace
Solved by running an initContainer that validates GKE metadata is ready for the pod: https://cloud.google.com/kubernetes-engine/docs/troubleshooting/troubleshooting-security#workload-identity