Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use substratus namespace in k8s config #188

Merged
merged 2 commits into from
Aug 12, 2023
Merged

use substratus namespace in k8s config #188

merged 2 commits into from
Aug 12, 2023

Conversation

samos123
Copy link
Contributor

@samos123 samos123 commented Aug 11, 2023 •
edited

I verified that the following command results in no changes:

make installation-manifests

So I think it should cause no issues

@samos123 samos123 requested a review from nstogner August 11, 2023 21:10
brandonjbjelland
brandonjbjelland approved these changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@brandonjbjelland brandonjbjelland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

12 results matches my local search. lgtm

@nstogner nstogner merged commit 426d439 into main Aug 12, 2023
4 checks passed
@nstogner nstogner deleted the k8s-config-use-substratus-ns branch August 12, 2023 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandonjbjelland brandonjbjelland brandonjbjelland approved these changes

@nstogner nstogner Awaiting requested review from nstogner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@samos123 @brandonjbjelland @nstogner