remove configmap from kubernetes/gcp/system.yaml #198
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required for having an installation flow that creates the configmap as part of the flow. For example, I would like to do this in the installation guide:
create and apply a configmap:
and then tell user to install the operator:
So the issue here is that
kubectl apply -f kubernetes/gcp/system.yaml
shouldn't also include that same configmap. This PR removes the configmap from kubernetes/gcp/system.yaml