Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove configmap from kubernetes/gcp/system.yaml #198

Merged
merged 2 commits into from
Aug 17, 2023

Conversation

samos123
Copy link
Contributor

This is required for having an installation flow that creates the configmap as part of the flow. For example, I would like to do this in the installation guide:

create and apply a configmap:

kubectl apply -f - << EOF
apiVersion: v1
kind: ConfigMap
metadata:
  name: system
  namespace: substratus
data:
  CLOUD: gcp
  ARTIFACT_BUCKET_URL: gs://$PROJECT_ID-substratus-artifacts
  REGISTRY_URL: us-central1-docker.pkg.dev/my-project/substratus # auto configured
  # CLUSTER_NAME: substratus auto configured
  # PRINCIPAL: substratus@my-project.iam.gserviceaccount.com auto configured
  # PROJECT_ID: my-project auto configured
  # CLUSTER_LOCATION: us-central1 auto configured
EOF

and then tell user to install the operator:

kubectl apply -f kubernetes/gcp/system.yaml

So the issue here is that kubectl apply -f kubernetes/gcp/system.yaml shouldn't also include that same configmap. This PR removes the configmap from kubernetes/gcp/system.yaml

@samos123 samos123 merged commit 549c7d2 into main Aug 17, 2023
4 checks passed
@samos123 samos123 deleted the gcp-move-configmap-to-install branch August 17, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants