-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove terraform from GCP install #204
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
samos123
commented
Aug 21, 2023
- updates gcp to use new directory structure
- creates gke cluster and nodepools during up.sh
samos123
changed the title
remove terraform dependency from GCP
remove terraform from GCP install
Aug 21, 2023
samos123
force-pushed
the
update-gcp-install
branch
3 times, most recently
from
August 21, 2023 06:25
aabfd97
to
d5e5ed0
Compare
nstogner
reviewed
Aug 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really like the direction, I think you are missing install/gcp/manifests.yaml
* updates gcp to use new directory structure * creates gke cluster and nodepools during up.sh
samos123
force-pushed
the
update-gcp-install
branch
from
August 22, 2023 00:24
d5b290d
to
211f9b8
Compare
nstogner
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.