Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove terraform from GCP install #204

Merged
merged 14 commits into from
Aug 22, 2023
Merged

remove terraform from GCP install #204

merged 14 commits into from
Aug 22, 2023

Conversation

samos123
Copy link
Contributor

  • updates gcp to use new directory structure
  • creates gke cluster and nodepools during up.sh

@samos123 samos123 changed the title remove terraform dependency from GCP remove terraform from GCP install Aug 21, 2023
@samos123 samos123 force-pushed the update-gcp-install branch 3 times, most recently from aabfd97 to d5e5ed0 Compare August 21, 2023 06:25
@samos123 samos123 requested a review from nstogner August 21, 2023 06:56
Copy link
Contributor

@nstogner nstogner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really like the direction, I think you are missing install/gcp/manifests.yaml

Makefile Outdated Show resolved Hide resolved
install/gcp/up.sh Show resolved Hide resolved
install/gcp/up.sh Show resolved Hide resolved
@samos123 samos123 requested a review from nstogner August 22, 2023 00:14
@nstogner nstogner added this pull request to the merge queue Aug 22, 2023
Merged via the queue into main with commit a3dd50c Aug 22, 2023
1 check passed
@nstogner nstogner deleted the update-gcp-install branch August 22, 2023 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants