Add env support and remove params from env #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make working with Hugging Face tokens easier. This would allow you to create a secret with the following content: ``` HUGGING_FACE_HUB_TOKEN: my-token ``` Afterwards all Substratus resources will be able to use this HuggingFace token. This also removes the need for custom entrypoints in the images that strip PARAM_ from the env variable.
nstogner
reviewed
Sep 4, 2023
samos123
changed the title
samos123
changed the title
samos123
changed the title
nstogner
requested changes
Sep 5, 2023
samos123
commented
Sep 5, 2023
| @@ -314,9 +314,14 @@ func nbPodName(nb *apiv1.Notebook) string { | |||
| } | |||
|
|
|||
| // notebookPod constructs a Pod for the given Notebook. | |||
| func (r *NotebookReconciler) notebookPod(notebook *apiv1.Notebook, model *apiv1.Model, dataset *apiv1.Dataset) (*corev1.Pod, error) { | |||
| func (r *NotebookReconciler) notebookPod(ctx context.Context, notebook *apiv1.Notebook, model *apiv1.Model, dataset *apiv1.Dataset) (*corev1.Pod, error) { | |||
There was a problem hiding this comment.
I can remove the ctx here since it's technically not needed anymore after latest refactor. What you think? @nstogner
|
PR for updating the images: substratusai/images#45 . I will also start updating the examples |
|
Verified on Kind with this model: |
nstogner
previously approved these changes
Sep 5, 2023
internal/controller/utils_test.go
Outdated
|
|
||
| actual, err := resolveEnv(tc.input) | ||
| if err != nil { | ||
| t.Errorf("error with case %v: %v", tc.input, err) |
There was a problem hiding this comment.
Prefer to use assert or require pkg
There was a problem hiding this comment.
Same for equality check below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow setting environment variables directly from the Substratus resources.
E.g.
This also removes the functionality of Substratus of setting
PARAM_environment variables. So this will require updating our images and possibly examples.