Added detection and status messages for bailout to OC / switch back to CC for CCR dives. #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeller
force-pushed
the
added_garmin_ccr_bailout_messages
branch
4 times, most recently
from
bd1dca7
to
39a9109
Compare
mikeller
added a commit
to mikeller/libdc
that referenced
this pull request
Jan 17, 2023
Pushed access to cached fields down into `field-cache.c` from parsers that use the field cache. As a result, all cached fields will be available to Subsurface in computer models that use the field cache. In particular this means that, together with subsurface#41, the proper use type (diluent / OC bailout) of tanks will be shown for the Garmin Descent dive computers (others to follow). Signed-off-by: Michael Keller <github@ike.ch>
mikeller
added a commit
to mikeller/libdc
that referenced
this pull request
Jan 17, 2023
Pushed access to cached fields down into `field-cache.c` from parsers that use the field cache. As a result, all cached fields will be available to Subsurface in computer models that use the field cache. In particular this means that, together with subsurface#41, the proper use type (diluent / OC bailout) of tanks will be shown for the Garmin Descent dive computers (others to follow). Signed-off-by: Michael Keller <github@ike.ch>
mikeller
force-pushed
the
added_garmin_ccr_bailout_messages
branch
from
8742f55
to
65bab71
Compare
|
I hate to ask, but is it possible to get some traction on this one? |
|
I poked Linus - he doesn't always see GitHub notifications. |
|
Hmm. The commit message is a bit of a mess on that first commit, with overlong lines (that's a 702-character line!) We had that earlier with the "Added parsing of the CCR setpoint information for Garmin Descent computers." that I merged as part of "added_garmin_ccr_setpoint_info", and I dread getting more of these. But the changes look sane per se. |
mikeller
force-pushed
the
added_garmin_ccr_bailout_messages
branch
from
65bab71
to
3f5b542
Compare
This might need a bit of discussion.
As a CCR diver I would like to see the ability to properly track the 'on loop' /
'bailed out to open circuit' status directly in Subsurface, because this is an
important (or even the most important) bit of status information during a CCR
dive. This should extend to the use of the correct ppO2 / gas mix in the deco
ceiling / tissue model calculation. My idea for how to do this would be to track
the 'type' ('diluent' / 'OC bailout') for every gasmix / tank that is reported
by the dive computer. Most CCR capable dive computers that I am familiar with
require the user to enter two different gas lists for diluent and bailout, so
this should work with the existing libdivecomputer API for these. Unfortunately
I think making this change in Subsurface will require a bit of work, as the
libdivecomputer field capable of tracking the 'type' of a gas or tank
(`cache->tankinfo[]`) does not seem to be consumed at all in Subsurface. So this
pull request is just providing a prerequisite for the change in Subsurface by
populating `tankinfo[]`. In addition to this it also triggers a message on every
switch from CC to OC and back, at least giving a visual indication of these
diver triggered events. The messages can probably be removed from
libdivecomputer again once 'loop status' tracking has been added to Subsurface.
Also included is a fix of the tab expansion mess that I created in
subsurface#40. Apologies for this, I've switched
to using a custom `.vimrc` for this project now.
Signed-off-by: Michael Keller <github@ike.ch>
mikeller
force-pushed
the
added_garmin_ccr_bailout_messages
branch
from
3f5b542
to
2b5d618
Compare
|
Apologies, I am new to the approach to add a detailed description of the changes to the commit message, instead of adding it to the pull request, and did not take care to rewrap my commit messages after editing. Fixed now. |
|
Cherry-picked the one remainming commit in the updated pull. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might need a bit of discussion.
As a CCR diver I would like to see the ability to properly track the 'on loop' / 'bailed out to open circuit' status directly in Subsurface, because this is an important (or even the most important) bit of status information during a CCR dive. This should extend to the use of the correct ppO2 / gas mix in the deco ceiling / tissue model calculation. My idea for how to do this would be to track the 'type' ('diluent' / 'OC bailout') for every gasmix / tank that is reported by the dive computer. Most CCR capable dive computers that I am familiar with require the user to enter two different gas lists for diluent and bailout, so this should work with the existing libdivecomputer API for these.
Unfortunately I think making this change in Subsurface will require a bit of work, as the libdivecomputer field capable of tracking the 'type' of a gas or tank (
cache->tankinfo[]) does not seem to be consumed at all in Subsurface. So this pull request is just providing a prerequisite for the change in Subsurface by populatingtankinfo[]. In addition to this it also triggers a message on every switch from CC to OC and back, at least giving a visual indication of these diver triggered events. The messages can probably be removed from libdivecomputer again once 'loop status' tracking has been added to Subsurface.Also included is a fix of the tab expansion mess that I created in #40. Apologies for this, I've switched to using a custom
.vimrcfor this project now.Signed-off-by: Michael Keller github@ike.ch