Distinguish internally between min pressure and end pressure #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And don't artificially end dives on min pressure This may be a problem for dive computers like Linus' Suunto Vyper Air where the failure mode seems to be _high_ pressure readings (that's scary, btw). If the transmitter fails at the end of the dive the pressure plot ends with incorrect high pressure. But that's simply a bug with the dive computer and not something that subsurface should hack around. Maybe we should offer a way to edit the incorrect data points instead. Always ending on the minimum pressure is definitely wrong as it causes bogus plots when you do a valve shutdown during the dive (which means that valid data gets plotted incorrectly). Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
3 tasks
This was referenced Jan 2, 2019
Merged
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cbcfcdd fixes only part of the problem - the program logic uses minpressure at a couple of spots where it really needs to use an endpressure
Don't artificially end dives on min pressure
This may be a problem for dive computers like Linus' Suunto Vyper Air
where the failure mode seems to be high pressure readings (that's scary,
btw). If the transmitter fails at the end of the dive the pressure plot
ends with incorrect high pressure. But that's simply a bug with the dive
computer and not something that subsurface should hack around. Maybe we
should offer a way to edit the incorrect data points instead.
Always ending on the minimum pressure is definitely wrong as it causes
bogus plots when you do a valve shutdown during the dive (which means that
valid data gets plotted incorrectly).
Signed-off-by: Dirk Hohndel dirk@hohndel.org