prepare_sample reallocs the dive - don't keep pointers around

[dirkhh]

Thanks Valgrind

This diff looks pointless at first until you see that I reference dive
again earlier in the loop and then after the end of the loop.

Signed-off-by: Dirk Hohndel dirk@hohndel.org

[torvalds]

On Sun, Oct 2, 2011 at 10:44 AM, Dirk Hohndel
reply@reply.github.com
wrote:

Thanks Valgrind

This diff looks pointless at first until you see that I reference dive
again earlier in the loop and then after the end of the loop.

Pulled and pushed out.

Btw, I'm looking at the equipment editing right now, and I have to say
that if I add cylinder start/end pressures and Helium percentages, the
window grows way too much horizontally.

And I tried making it vertical (ie add those things below the type and
working pressure etc), and that is just ugly and would also make it
use too much vertical space if we have more than two cylinders and
start adding other equipment. I threw away all my trials, they really
didn't seem to work.

So now I'm wondering if I should make the cylinder widgets
non-editable - which makes them much smaller widgets - and then have
an edit/del buttons next to it. And bring up a "cylinder edit dialog"
for when you want to edit the cylinder. That would also be where the
Ok/Cancel buttons would go.

What do you think? It adds another layer of indirection, and requires
you to click that "edit" button to edit the cylinder info, which
sounds very annoying if you edit multiple dives and want to fix up
cylinder information. But it sounds ok on an "individual dive" level
when you're just adding info for a single dive.

               Linus