fix: debug deserialization for SP1ProofWithIO. Test. #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puma314
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the type
Proofimplemented a custom serializer which hex encoded the proof data but did not implement a corresponding deserializer. This caused roundtrip deserialization to fail.This PR makes two improvements. First, it adds a custom deserializer for the
Prooftype. Second, it addshexencoding only when the target serialization format is human-readable - eliminating overhead in binary formats. This PR also adds tests on roundtrip encoding for theSP1ProofWithIOtype, which containsProof.Fixes #247