feat: derive MachineAir, chip and machine cleanup
#278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamirhemo
force-pushed
the
tamir/machine-cleanup
branch
from
a1bba8b
to
2eeefa6
Compare
tamirhemo
changed the title
MachineAir, chip and machine cleanup
kevjue
reviewed
Feb 21, 2024
| Blake3Compress(Blake3CompressInnerChip), | ||
| } | ||
|
|
||
| impl<F: PrimeField32> RiscvAir<F> { |
There was a problem hiding this comment.
I feel like if you are going to go the derive route, then included should also be derived?
core/src/stark/machine.rs
Outdated
| if !shard.program_memory_record.is_empty() { | ||
| chips.push(self.program_memory_init.as_ref()); | ||
| } | ||
| pub fn dyn_chips(&self) -> Vec<ChipRef<SC>> { |
There was a problem hiding this comment.
I feel like there def. should be a comment that this is used for non critical functions (e.g. debug_interactions).
Or maybe just do away with it? Like go all in with derive?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.