chore: refactor air in keccak to not use offset_of
#308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamirhemo
changed the title
offset_ofoffset_of
kevjue
approved these changes
Feb 24, 2024
| pub const NUM_KECCAK_COLS: usize = size_of::<KeccakCols<u8>>(); | ||
| pub const P3_KECCAK_COLS_OFFSET: usize = offset_of!(KeccakCols<u8>, p3_keccak_cols); | ||
| pub const NUM_KECCAK_MEM_COLS: usize = size_of::<KeccakMemCols<u8>>(); | ||
| // pub const P3_KECCAK_COLS_OFFSET: usize = offset_of!(KeccakCols<u8>, p3_keccak_cols); |
|
|
||
| use self::columns::P3_KECCAK_COLS_OFFSET; | ||
| // use self::columns::P3_KECCAK_COLS_OFFSET; |
tamirhemo
changed the title
offset_ofoffset_of
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the plonky3 Keccak air columns from the column struct so that we don't have to worry about offset.