perf: enable reconstruct trace/commit by default instead of using disk + lower memory usage #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtguibas
changed the title
tamirhemo
reviewed
Feb 27, 2024
core/src/stark/types.rs
Outdated
| @@ -64,7 +64,7 @@ impl<SC: StarkGenericConfig> ShardMainData<SC> { | |||
| where | |||
| ShardMainData<SC>: Serialize, | |||
| { | |||
| let mut writer = BufWriter::new(&file); | |||
| let mut writer = BufWriter::with_capacity(1024 * 1024 * 512, &file); | |||
There was a problem hiding this comment.
Should this capacity be some env variable as well?
There was a problem hiding this comment.
Going to remove this as I didn't notice any speedup from it.
tamirhemo
reviewed
Feb 27, 2024
| @@ -476,6 +476,12 @@ pub(super) mod baby_bear_blake3 { | |||
| } | |||
| } | |||
|
|
|||
| impl Clone for BabyBearBlake3 { | |||
There was a problem hiding this comment.
where do we need to clone the config?
There was a problem hiding this comment.
Right now it's required in prove_with_config, but maybe it's not necessary?
There was a problem hiding this comment.
I just removed the bound and it seems fine.
tamirhemo
approved these changes
Feb 27, 2024
jtguibas
added a commit
that referenced
this pull request
Mar 29, 2024
…k + lower memory usage (#323) Co-authored-by: John Guibas <jtguibas@Johns-MBP.monkeybrains.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.