Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rename to upper camel case #325

Merged
merged 1 commit into from Feb 27, 2024
Merged

chore: rename to upper camel case #325

merged 1 commit into from Feb 27, 2024

Conversation

jtguibas
Copy link
Contributor

@jtguibas jtguibas commented Feb 27, 2024 •
edited

Being pedantic here, but the Rust naming convention is
In UpperCamelCase, acronyms and contractions of compound words count as one word: use Uuid rather than UUID, Usize rather than USize or Stdin rather than StdIn.
It looks like SP1 mostly uses the opposite convention, with SWCurve, AUIPCCols, etc. Would your preference be to stick with that? I think that's fine too, probably noone takes the guideline too seriously, just wanted to check what the preference is going forward.

@jtguibas jtguibas merged commit b94e34b into main Feb 27, 2024
7 checks passed
@jtguibas jtguibas deleted the john/upper-camel-case-2 branch February 27, 2024 18:42
jtguibas added a commit that referenced this pull request Mar 29, 2024
@jtguibas
chore: rename to upper camel case (#325)
c9d6460 
Co-authored-by: John Guibas <jtguibas@Johns-MBP.monkeybrains.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tamirhemo tamirhemo tamirhemo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jtguibas @tamirhemo