-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jest-like simple interface #6
Comments
Further thoughts: You could allow users to define some config for how their snapshots will be output e.g. chai.use(chaiJestSnapshot({
// To match jest
path: '__snapshots__', // relative or root
suffix: '.snap',
// Additional options
prefix: 'snapshot'
})); Possibly allow outputting versions as Jest does (which could be configured by users): // Jest Snapshot v1, https://goo.gl/fbAQLP |
@JakeSidSmith @suchipi I made it in #7 |
Thanks @truongsinh. I will try to take a look and offer a proper review sometime either this weekend or next. Also sorry I didn't reply to this earlier @JakeSidSmith, I looked at it from the notification which marked it as read, and then forgot about it |
@suchipi that's kwl, done the same a bunch of times. @truongsinh had quick look at that PR, and looks good. Will take a better look a bit later. :) |
hi @suchipi, how is it going? |
Hi, @truongsinh, I haven't forgotten about you, I just had a busy weekend. I'll try to look at this sometime this weekend |
This was completed in #7 and I forgot to close this issue |
Started using
chai-jest-snapshot
recently withmocha
, but I fear my colleagues will not like the additional effort of supplying a filepath & name for each snapshot.Do you have any plans to allow a default / automatic filepath / name so that assertions can simply be made with:
I'd love to help out if I can.
P.s. Additionally an easier way to update all snapshots would be nice, but I've not had any thoughts about ways to improve it yet. But if it were possible to do so with
mocha -u
(or similar, as this is already used for--ui
), that'd be awesome.The text was updated successfully, but these errors were encountered: