Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more iconsets #39

Closed
6 tasks done
jerone opened this issue May 14, 2015 · 4 comments · Fixed by #46
Closed
6 tasks done

Support more iconsets #39

jerone opened this issue May 14, 2015 · 4 comments · Fixed by #46

Comments

@jerone
Copy link
Contributor

jerone commented May 14, 2015

Finding the right icon isn't always that easy. When I need one I search on http://glyphsearch.com

@MrLoh
Copy link

MrLoh commented May 25, 2015

I think it would be even better, to allow adding custom svg icons. I'd like to add a shortcut to the grunt plugin to my toolbar for example. Not going to find that in any icon font, but a pretty common scenario

@jerone
Copy link
Contributor Author

jerone commented May 25, 2015

@MrLoh commented on 25 mei 2015 11:59 CEST:

I think it would be even better, to allow adding custom svg icons. I'd like to add a shortcut to the grunt plugin to my toolbar for example. Not going to find that in any icon font, but a pretty common scenario

Interesting idea. How did you think of referencing that icon? Atm moment only fonts are allowed.

@jerone jerone mentioned this issue May 25, 2015
2 tasks
@MrLoh
Copy link

MrLoh commented May 25, 2015

@jerone I haven't looked at how the icons are implemented here at the moment, but just providing a path to a file shouldn't be any problem, this is all based on web technologies anywys. Maybe I'll find time to look into it and make a pull request.

@jerone jerone self-assigned this May 26, 2015
@jerone
Copy link
Contributor Author

jerone commented May 26, 2015

@MrLoh commented on 26 mei 2015 01:09 CEST:

I haven't looked at how the icons are implemented here at the moment, but just providing a path to a file shouldn't be any problem, this is all based on web technologies anywys. Maybe I'll find time to look into it and make a pull request.

I moved your request to another issue: #48

jerone added a commit that referenced this issue May 26, 2015
@jerone jerone mentioned this issue May 30, 2015
@jerone jerone removed their assignment Jul 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants