Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete Taxonomy Terms - Based on post count #177

Closed
5 tasks done
sudar opened this issue Dec 31, 2017 · 5 comments
Closed
5 tasks done

Delete Taxonomy Terms - Based on post count #177

sudar opened this issue Dec 31, 2017 · 5 comments
Labels
feature
Milestone
6.0.0

Comments

@sudar
Copy link
Owner

sudar commented Dec 31, 2017 •
edited by rajanvijayan
Loading

  • Create a new module with the name 'Delete Taxonomy Terms by post count' in the Delete Terms page.
  • Choose the taxonomy. Single select dropdown. Create Helper functions in Renderer.
  • Choose the post type. Single select dropdown.
  • A dropdown to choose the operation. Possible values (not equal to, equal to, less than, greater than)
  • A textbox to enter the post count.
@sudar sudar added this to the 5.8 milestone Dec 31, 2017
@sudar sudar added Next Sprint Workflow Label: Should be done by next Sprint feature labels Dec 31, 2017
@sudar sudar added Current Sprint Workflow Label: Should be done this sprint and removed Next Sprint Workflow Label: Should be done by next Sprint labels May 22, 2018
This was referenced May 29, 2018
Closed
Closed
@rajanvijayan
Copy link
Contributor

Could not pass post type in taxonomy query, and could not get post counts for selected post counts

rajanvijayan added a commit that referenced this issue Jun 25, 2018
@rajanvijayan
Done Delete Taxonomy Terms - Based on post count
9326974 
Fix #177
@rajanvijayan rajanvijayan mentioned this issue Jun 25, 2018
Merged
4 tasks
@sudar
Copy link
Owner Author

sudar commented Jun 26, 2018

This is done as part of #332

@sudar sudar added In Progress Workflow Label: Current in progress and removed Current Sprint Workflow Label: Should be done this sprint labels Jun 26, 2018
@rajanvijayan
Copy link
Contributor

rajanvijayan commented Jul 9, 2018 •
edited by sudar
Loading

Development done. Pull request is at #332

Need to fix Codacy issues.

@sudar sudar modified the milestones: 6.1.0, 6.0.0 Jul 24, 2018
@mariadanieldeepak
Copy link
Collaborator

mariadanieldeepak commented Aug 1, 2018 •
edited
Loading

@rajanit2000,

There is a blocker.

Screenshot: Data setup

image

Screenshot: Deletion criteria

image

Screenshot: Output

The expected result is 1, but looking at the screenshot it is clear that the module isn't deleting terms.

image

When you fix this issue, I would like you to test all the scenarios in the module. For each scenario, I would like to see the following

  • Take screenshot of the data setup
  • Take a screenshot of the module setup
  • Take a screenshot of the Output
  • Take a screenshot of the WP CLI output

Please be shrewd and do a self review before sending it to the actual review.

@mariadanieldeepak
Copy link
Collaborator

@rajanit2000

Did you get a chance to see the above comment?

sudar pushed a commit that referenced this issue Aug 12, 2018
@rajanvijayan @sudar
Add the ability to delete terms
382cbc6 
The following modules are added along with their tests

- DeleteTermsByName
- DeleteTermsByPostCount

Fix #19 
Fix #176 
Fix #177 
Fix #178
Fix #348
Fix #349
@ghost ghost removed the In Progress Workflow Label: Current in progress label Aug 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
6.0.0
Development

No branches or pull requests
3 participants
@sudar @rajanvijayan @mariadanieldeepak