Add test case for delete term meta module #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
@sudar development finished ready to review |
sudar
requested changes
Aug 10, 2018
| /** | ||
| * Add to test delete default taxonomy term meta with equal value. | ||
| */ | ||
| public function test_that_delete_default_taxonomy_term_meta_with_equal_value() { |
There was a problem hiding this comment.
Function name is not following the test_that_something_can_be_deleted format.
Change it for all the methods.
| 'term_meta_option' => 'equal', | ||
| ); | ||
|
|
||
| $meta_deleted = $this->module->delete( $delete_options ); |
There was a problem hiding this comment.
You also need to add some terms that won't be deleted in the test cases.
Add explicit checks Fix #350
|
@sudar Its ready to review |
sudar
requested changes
Aug 12, 2018
| // Assert that post meta deleted. | ||
| $this->assertEquals( 1, $meta_deleted ); | ||
|
|
||
| $meta = get_term_meta( $term_array['term_id'], 'another' ); |
There was a problem hiding this comment.
In add_term_meta you are using the value Another and here you are checking for another.
Make sure you store the value in a variable before accessing it.
This problem is happening in all test cases. Fix it in all places.
|
@sudar its ready to review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #350
Blocked by #247