feat: Add CPM and Rust support #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudara
reviewed
Apr 26, 2024
There was a problem hiding this comment.
This is great! Looking forward to transitioning things over to CPM, I think that'll be a nicer experience.
Re: Rust, we should find a way to give people what they need on the Pamplejuce side while having it be optional (disabled by default). Not sure what that really means because I don't really know what else has to be in place besides including Rust.cmake.
| @@ -0,0 +1,39 @@ | |||
| # Dependencies that are downloaded using the CPM package manager | |||
| include("${CMAKE_CURRENT_LIST_DIR}/CPM.cmake") | |||
There was a problem hiding this comment.
Will this be a problem if CPM is already included? Do we need something like https://cmake.org/cmake/help/latest/command/include_guard.html ?
| # SPDX-FileCopyrightText: Copyright (c) 2019-2023 Lars Melchior and contributors | ||
|
|
||
| set(CPM_DOWNLOAD_VERSION 0.38.7) | ||
| set(CPM_HASH_SUM "83e5eb71b2bbb8b1f2ad38f1950287a057624e385c238f6087f94cdfc44af9c5") |
There was a problem hiding this comment.
What's the best practice for finding this hash and bumping the version, etc?...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for using the CPM package manager as well as Rust.
Once this PR is merged, I can add Rust boiler plate to Pamplejuce :)