Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.0 Release #33

Merged
merged 22 commits into from Aug 29, 2023
Merged

1.0 Release #33

merged 22 commits into from Aug 29, 2023

Conversation

sudara
Copy link
Owner

@sudara sudara commented Aug 6, 2023

This is a big bundle o 1.0 joy.

The only thing that didn't make the release this time was packages support for macOS.

Still doing .dmg releases. Which is funny, because drag and dropping plugins from DMG is fixed and working again as of Ventura.

Anyway, this PR bundles the following:

f637d79 attempted to fix #31 by putting the juce modules (and third party modules) back to PRIVATE visibility. See that issue for details on why this needs to be the case in JUCE.

Unfortunately, that fix doesn't account for the fact that differing compile definitions may be desired on each target. For example we might want to set JUCE_MODAL_LOOPS_PERMITTED=1 in tests to be able to run the MessageManager so callbacks fire, or set something like RUN_MY_TESTS=1 so that tests in source files and module directories will run. Trying to add additional definitions via target_compile_definitions wasn't working.

This PR implements @chrhaase's suggestion of sticking all app code and config in an INTERFACE target so that it can be shared between the various juce plugin targets as well as the Tests target.

@sudara sudara changed the title Shared code interface Add SharedCode INTERFACE target Aug 6, 2023
@sudara sudara changed the title Add SharedCode INTERFACE target 1.0 Release Aug 28, 2023
@sudara sudara merged commit 1c32a80 into main Aug 29, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment