Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When sudo_mmap_strdup fails, copy[x] may be leaked? #202

Closed
BornThisWay opened this issue Nov 18, 2022 · 1 comment
Closed

When sudo_mmap_strdup fails, copy[x] may be leaked? #202

BornThisWay opened this issue Nov 18, 2022 · 1 comment

Comments

@BornThisWay
Copy link
Contributor

sudo/src/sudo_intercept.c

Line 99 in ad220d7

sudo_mmap_free(copy);

I don't think the resource rollback is complete.
@BornThisWay BornThisWay mentioned this issue Nov 18, 2022
Closed
millert added a commit that referenced this issue Nov 18, 2022
@millert
copy_vector: plug memory leak in error path
9c694e9 
Only the array was being freed, not the contents.
GitHub issue #202.
@millert
Copy link
Collaborator

millert commented Nov 18, 2022

Fixed by 9c694e9

@millert millert closed this as completed Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@millert @BornThisWay