Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.9.13: auoreconf fails because AC_SYS_YEAR2038 acloacal macro is missing #242

Closed
kloczek opened this issue Feb 16, 2023 · 8 comments
Closed

Comments

@kloczek
Copy link

kloczek commented Feb 16, 2023

I cannot initialize source tree of the 1.9.13: because autoreconf cnnot find AC_SYS_YEAR2038 acloacal macro.

+ cd sudo-1.9.13
+ autoreconf -fiv
autoreconf: export WARNINGS=
autoreconf: Entering directory '.'
autoreconf: configure.ac: not using Gettext
autoreconf: running: aclocal --force
autoreconf: configure.ac: tracing
autoreconf: running: libtoolize --copy --force
libtoolize: putting auxiliary files in AC_CONFIG_AUX_DIR, 'scripts'.
libtoolize: copying file 'scripts/ltmain.sh'
libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'm4'.
libtoolize: copying file 'm4/libtool.m4'
libtoolize: copying file 'm4/ltoptions.m4'
libtoolize: copying file 'm4/ltsugar.m4'
libtoolize: copying file 'm4/ltversion.m4'
libtoolize: copying file 'm4/lt~obsolete.m4'
libtoolize: Consider adding '-I m4' to ACLOCAL_AMFLAGS in Makefile.am.
autoreconf: configure.ac: not using Intltool
autoreconf: configure.ac: not using Gtkdoc
autoreconf: running: aclocal --force
autoreconf: running: /usr/bin/autoconf --force
configure.ac:2442: error: possibly undefined macro: AC_SYS_YEAR2038
      If this token and others are legitimate, please use m4_pattern_allow.
      See the Autoconf documentation.
autoreconf: error: /usr/bin/autoconf failed with exit status: 1

Q: where is that macro? 🤔

@kanavin
Copy link

kanavin commented Feb 16, 2023

The macro has been added to autoconf recently, and there is not yet a tagged release that has it:
https://git.savannah.gnu.org/cgit/autoconf.git/commit/lib/autoconf/specific.m4?id=f6657256a37da44c987c04bf9cd75575dfca3b60

Certainly, not in the autoconf version that sudo requires:

AC_PREREQ([2.70])

I agree that relying on it in a released sudo version is premature, and should be reverted.

@kloczek
Copy link
Author

kloczek commented Feb 16, 2023

I'm unig 2.71.
If it was not released I think that t would be good to add that macro to acinclude.m4.

@kanavin
Copy link

kanavin commented Feb 16, 2023

I'm using 2.71 too, the latest released version. The macro is not there.

millert added a commit that referenced this issue Feb 16, 2023
Otherwise, use the method from 1.9.12.
GitHub issue #242
@millert
Copy link
Collaborator

millert commented Feb 16, 2023

Sorry, I had expected autoconf 2.7.2 to be released already. I just committed a fix to only call AC_SYS_YEAR2038 if it is defined. Otherwise, it will use the method used in sudo 1.9.12.

@millert
Copy link
Collaborator

millert commented Feb 16, 2023

I plan to release 1.9.13p1 on Monday with this and other minor build-related fixes.

@kanavin
Copy link

kanavin commented Feb 16, 2023

Thanks!

@millert
Copy link
Collaborator

millert commented Feb 17, 2023

This is fixed in sudo 1.9.13p1, available now.

@millert millert closed this as completed Feb 17, 2023
@kloczek
Copy link
Author

kloczek commented Feb 17, 2023

Just tested p1 and looks like indeed issue has been resolved 👍
Thank you 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants