Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix context swtich in block hooks #45

Closed
robcxyz opened this issue Mar 15, 2022 · 0 comments
Closed

Fix context swtich in block hooks #45

robcxyz opened this issue Mar 15, 2022 · 0 comments

Comments

@robcxyz
Copy link
Collaborator

robcxyz commented Mar 15, 2022

Block hooks currently create a new context that loses the reference to the main output_dict during execution and the output is then inserted into a key. This works and has the added advantage of maintaining a new context keyed on the level that the parsing is done but this makes it impossible to set keys outside of the block context.

Would be nice if we had the best of both worlds, the context on the same level of the block but also as the block is parsed, the output is put directly into the top level output_dict. If this was the case, the output_dict of the block hook could be the same but you would need to have some carved out logic for setting keys to be able to insert based on a new key path.

WIP issue...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant