Fix wrapping in <button> when created in JS #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (toCopy = this.getAttribute('target-text')) { | ||
| return copy(toCopy); | ||
| function handleCopyClick(event) { | ||
| if (event.defaultPrevented) return; |
There was a problem hiding this comment.
This one is breaking too. Now mimics other controls. Default behavior may be prevented on capturing.
|
Looks good, would happily merge! What do you think: do we need to update |
|
I am pretty sure we should not specify a specific shim in Roadmap: transit to V1, upgrade API as I mentioned in #5, move shim from |
|
However, for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating
<copy-button>in JavaScript like this:will result in
hello, worldnot being wrapped in<button>, because wrapping happens on line 1 and created<button>gets deleted on line 2.I would say this PR is breaking (because of
onclickand IE8 support) and deserves2.0.