Merge 2197661 into 567fef9

sue445 · Jan 6, 2023 · 718566d · 718566d
2 parents 567fef9 + 2197661
commit 718566d
Show file tree

Hide file tree

Showing 10 changed files with 23 additions and 1 deletion.
diff --git a/Gemfile b/Gemfile
@@ -2,3 +2,5 @@ source 'https://rubygems.org'
 
 # Specify your gem's dependencies in activerecord-compatible_legacy_migration.gemspec
 gemspec
+
+eval_gemfile "#{__dir__}/gemfiles/common.gemfile"
diff --git a/activerecord-compatible_legacy_migration.gemspec b/activerecord-compatible_legacy_migration.gemspec
@@ -28,7 +28,6 @@ Gem::Specification.new do |spec|
   spec.add_dependency "activerecord", ">= 4.0.0"
 
   spec.add_development_dependency "bundler", ">= 1.12"
-  spec.add_development_dependency "coveralls"
   spec.add_development_dependency "rails"
   spec.add_development_dependency "rake"
   spec.add_development_dependency "rspec"

diff --git a/gemfiles/common.gemfile b/gemfiles/common.gemfile
@@ -0,0 +1,7 @@
+if Gem::Version.create(RUBY_VERSION) < Gem::Version.create("2.4.0")
+  # FIXME: coveralls_reborn cannot be installed due to dependencies with json and rails 4.x
+  # c.f. https://github.com/sue445/activerecord-compatible_legacy_migration/actions/runs/3854778531/jobs/6569131703
+  gem "coveralls"
+else
+  gem "coveralls_reborn"
+end
diff --git a/gemfiles/rails_4_0.gemfile b/gemfiles/rails_4_0.gemfile
@@ -3,4 +3,6 @@ source "https://rubygems.org"
 gem "rails", "~> 4.0.0"
 gem "sqlite3", "~> 1.3.6"
 
+eval_gemfile "#{__dir__}/common.gemfile"
+
 gemspec path: '../'
diff --git a/gemfiles/rails_4_1.gemfile b/gemfiles/rails_4_1.gemfile
@@ -3,4 +3,6 @@ source "https://rubygems.org"
 gem "rails", "~> 4.1.0"
 gem "sqlite3", "~> 1.3.6"
 
+eval_gemfile "#{__dir__}/common.gemfile"
+
 gemspec path: '../'
diff --git a/gemfiles/rails_4_2.gemfile b/gemfiles/rails_4_2.gemfile
@@ -3,4 +3,6 @@ source "https://rubygems.org"
 gem "rails", "~> 4.2.0"
 gem "sqlite3", "~> 1.3.6"
 
+eval_gemfile "#{__dir__}/common.gemfile"
+
 gemspec path: '../'
diff --git a/gemfiles/rails_5_0.gemfile b/gemfiles/rails_5_0.gemfile
@@ -3,4 +3,6 @@ source "https://rubygems.org"
 gem "rails", "~> 5.0.0"
 gem "sqlite3", "~> 1.3.6"
 
+eval_gemfile "#{__dir__}/common.gemfile"
+
 gemspec path: '../'
diff --git a/gemfiles/rails_5_1.gemfile b/gemfiles/rails_5_1.gemfile
@@ -3,4 +3,6 @@ source "https://rubygems.org"
 gem "rails", "~> 5.1.0"
 gem "sqlite3", "~> 1.3.6"
 
+eval_gemfile "#{__dir__}/common.gemfile"
+
 gemspec path: '../'
diff --git a/gemfiles/rails_5_2.gemfile b/gemfiles/rails_5_2.gemfile
@@ -3,4 +3,6 @@ source "https://rubygems.org"
 gem "rails", "~> 5.2.0"
 gem "sqlite3", "~> 1.3.6"
 
+eval_gemfile "#{__dir__}/common.gemfile"
+
 gemspec path: '../'
diff --git a/gemfiles/rails_6_0.gemfile b/gemfiles/rails_6_0.gemfile
@@ -5,4 +5,6 @@ gem "rails", "~> 6.0.0"
 # c.f. https://github.com/rails/rails/blob/v6.0.0/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb#L13
 gem "sqlite3", "~> 1.4"
 
+eval_gemfile "#{__dir__}/common.gemfile"
+
 gemspec path: '../'