-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix support activerecord 7.1 #95
Conversation
The current implementation does not support defining index in `create_table`. AR 7.1 includes LegacyIndexName in two places. https://github.com/rails/rails/blob/v7.1.3.2/activerecord/lib/active_record/migration/compatibility.rb#L66 https://github.com/rails/rails/blob/v7.1.3.2/activerecord/lib/active_record/migration/compatibility.rb#L88
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@onk Only Ruby 2.7+Rails 7.1 case is failed to build.
https://github.com/sue445/activerecord-simple_index_name/actions/runs/8057350105/job/22012626022?pr=95
Can you fix this?
👀 # 2.7.8
# 3.4-dev
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The current implementation does not support defining index in
create_table
.AR 7.1 includes LegacyIndexName in two places.