Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support activerecord 7.1 #95

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Conversation

onk
Copy link
Contributor

@onk onk commented Feb 27, 2024

@sue445 sue445 self-requested a review February 27, 2024 03:00
Copy link
Owner

@sue445 sue445 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@sue445 sue445 self-requested a review February 27, 2024 03:34
Copy link
Owner

@sue445 sue445 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@onk
Copy link
Contributor Author

onk commented Feb 27, 2024

👀

# 2.7.8
[1] pry(#<CreateArticles>)> self.class.ancestors
=> [CreateArticles,
 ActiveRecord::Migration::Compatibility::V4_2,
 ActiveRecord::Migration::Compatibility::V5_0,
 ActiveRecord::Migration::Compatibility::V5_1,
 ActiveRecord::Migration::Compatibility::V5_2,
 ActiveRecord::Migration::Compatibility::V6_0,
 ActiveRecord::Migration::Compatibility::V6_1,
 ActiveRecord::Migration::Compatibility::V7_0,
 ActiveRecord::Migration::Compatibility::V7_0::LegacyIndexName,
 ActiveRecord::Migration::Current,
 ActiveRecord::Migration,
 ActiveSupport::ForkTracker::CoreExtPrivate,
 ActiveSupport::ForkTracker::CoreExt,
 ActiveSupport::ToJsonWithActiveSupportEncoder,
 ActiveSupport::Dependencies::RequireDependency,
 Object,
 PP::ObjectMixin,
 JSON::Ext::Generator::GeneratorMethods::Object,
 ActiveSupport::Tryable,
 Kernel,
 BasicObject]
# 3.4-dev

[1] pry(#<CreateArticles>)> self.class.ancestors
=> [CreateArticles,
 ActiveRecord::Migration::Compatibility::V4_2,
 ActiveRecord::Migration::Compatibility::V5_0,
 ActiveRecord::Migration::Compatibility::V5_1,
 ActiveRecord::Migration::Compatibility::V5_2,
 ActiveRecord::Migration::Compatibility::V6_0,
 ActiveRecord::Migration::Compatibility::V6_1,
 ActiveRecord::Migration::Compatibility::V7_0,
 ActiveRecord::SimpleIndexName::ActiveRecordExt_7_1::V7_0,
 ActiveRecord::Migration::Compatibility::V7_0::LegacyIndexName,
 ActiveRecord::Migration::Current,
 ActiveRecord::Migration,
 ActiveSupport::ToJsonWithActiveSupportEncoder,
 ActiveSupport::Dependencies::RequireDependency,
 Object,
 PP::ObjectMixin,
 JSON::Ext::Generator::GeneratorMethods::Object,
 ActiveSupport::Tryable,
 Kernel,
 BasicObject]

@sue445 sue445 self-requested a review February 27, 2024 06:46
Copy link
Owner

@sue445 sue445 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sue445 sue445 merged commit 1097b13 into sue445:master Feb 27, 2024
40 checks passed
@sue445
Copy link
Owner

sue445 commented Feb 27, 2024

I published v1.1.1 🚀
https://github.com/sue445/activerecord-simple_index_name/blob/master/CHANGELOG.md#v111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants