Skip to content

Commit

Permalink
Merge pull request #41 from sue445/remove_rake_tasks
Browse files Browse the repository at this point in the history
Refactor rbs on CI
  • Loading branch information
sue445 committed Jul 25, 2023
2 parents ce0e8d9 + 6c8b5de commit 01f4bc1
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 14 deletions.
25 changes: 22 additions & 3 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,6 @@ jobs:
bundle update --jobs $(nproc) --retry 3
- run: bundle exec rspec
- run: bundle exec rbs collection install
- run: bundle exec rake rbs_validate
# - run: bundle exec rake steep_check # TODO: Do after

- name: Slack Notification (not success)
uses: lazy-actions/slatify@master
Expand All @@ -57,9 +54,31 @@ jobs:
url: ${{ secrets.SLACK_WEBHOOK }}
token: ${{ secrets.GITHUB_TOKEN }}

rbs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v3

- uses: ruby/setup-ruby@v1
with:
ruby-version: ruby
bundler-cache: true

- name: bundle update
run: |
set -xe
bundle config path vendor/bundle
bundle update --jobs $(nproc) --retry 3
- run: bundle exec rbs collection install
- run: bundle exec rbs validate --silent
# - run: bundle exec steep check # TODO: Do after

notify:
needs:
- test
- rbs

runs-on: ubuntu-latest

Expand Down
12 changes: 1 addition & 11 deletions Rakefile
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,4 @@ require "rspec/core/rake_task"

RSpec::Core::RakeTask.new(:spec)

desc "validate rbs"
task :rbs_validate do
sh "rbs validate --silent"
end

desc "check steep"
task :steep_check do
sh "steep check"
end

task default: %i[spec rbs_validate steep_check]
task default: :spec

0 comments on commit 01f4bc1

Please sign in to comment.