Merge pull request #19 from sue445/fix_error

Avoid error
sue445 · Nov 25, 2023 · f22e440 · f22e440
2 parents e8ff815 + 1758fd2
commit f22e440
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/ruby/app.rb b/ruby/app.rb
@@ -151,6 +151,12 @@ def fill_livestream_response(tx, livestream_model)
       end
 
       def fill_livecomment_response(tx, livecomment_model)
+        # FIXME: livecomment_modelにnilが入っていることがある
+        # c.f
+        # * https://github.com/sue445/isucon13-20231125/issues/18
+        # * https://sue445.sentry.io/share/issue/90a9b3def2814770b1093fbaaa5b874d/
+        return unless livecomment_model
+
         comment_owner_model = tx.xquery('SELECT * FROM users WHERE id = ?', livecomment_model.fetch(:user_id)).first
         comment_owner = fill_user_response(tx, comment_owner_model)