Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing Rubicure#Series#girls and Precure.all_girls behavior #284

Open
sue445 opened this issue Jul 4, 2023 · 0 comments
Open

Changing Rubicure#Series#girls and Precure.all_girls behavior #284

sue445 opened this issue Jul 4, 2023 · 0 comments
Assignees
Milestone

Comments

@sue445
Copy link
Owner

sue445 commented Jul 4, 2023

Now, Precure.hirogaru_sky.girls.map(&:precure_name) returns Cure Wing

Precure.hirogaru_sky.girls.map(&:precure_name)
# => ["キュアスカイ", "キュアプリズム", "キュアウィング", "キュアバタフライ"]

This is same to Precure.all_girls

Precure.all_girls.include?(Cure.wing)
# => true

But Cure Wing is a boy 👦 , so it feels strange.

So I'm going to change this behavior in the next major version (v4)

@sue445 sue445 self-assigned this Jul 4, 2023
@sue445 sue445 added this to the v4 milestone Jul 4, 2023
sue445 added a commit that referenced this issue Jul 4, 2023
sue445 added a commit that referenced this issue Jul 4, 2023
@sue445 sue445 changed the title Changing Rubicure#Series#girls behavior Changing Rubicure#Series#girls and Precure.all_girls behavior Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant