Imrpove code quality #6
Conversation
.travis.yml
Outdated
| @@ -1,8 +1,9 @@ | |||
| language: elixir | |||
| elixir: | |||
| - 1.2 | |||
There was a problem hiding this comment.
Do we really want to drop the test case for Elixir 1.2 here? We're still testing Sugar itself on that version.
There was a problem hiding this comment.
Good point. Adding 1.2 back in to the build matrix
| :json -> [{"accept", "application/json"}] | ||
| :xml -> [{"accept", "application/xml"}] | ||
| # :json -> [{"accept", "application/json"}] | ||
| # :xml -> [{"accept", "application/xml"}] |
There was a problem hiding this comment.
Are these supposed to be removed? If so, should we consider getting rid of the add_header entirely, since it's unused at this point?
At the very least, we could prefix it as _add_header in the function signature and just resort to header = [] for the time being.
There was a problem hiding this comment.
These weren't used really anyways, but I've commented them here (as opposed to removing) because I'm circling back to actually implement this in the near future.
|
LGTM. Merge it 👍 |
/cc @YellowApple