DBZ-2975: Extract offset context from object states to method signatures #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8.
It should be possible to reuse the graph of components under
ChangeEventSourceCoordinator
for processing multiple partitions represented viaOffsetContext
sequentially. Specifically,StreamingChangeEventSource#execute()
andSnapshotChangeEventSource#execute()
should accept an offset context and explicitly pass it down the line.The following classes and hierarchies no longer have the offset context as part of their state which is now part of their interface:
ChangeEventSourceFactory
(including all connector implementations).SnapshotChangeEventSource
(including snapshot/streaming interfaces and all connector implementations).mysql.EventBuffer
).Certain classes are parametrized with
<O extends OffsetContext
>. Since the graph of components under theSourceTask
implementation will be dealing with a set of contexts, there may be no place to do typecasting for the entire set. Additionally, the use of parameterized types looks safer:BaseSourceTask
ChangeEventSourceCoordinator
ChangeEventSourceFactory
SnapshotChangeEventSource
SnapshotResult