This repository has been archived by the owner on Feb 23, 2019. It is now read-only.
Add a utils.assertSaneResponse method #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
rhoggSugarcrm
force-pushed
the
improve-error-logging
branch
2 times, most recently
from
a219702
to
b6f7ecb
Compare
rhoggSugarcrm
force-pushed
the
improve-error-logging
branch
from
b6f7ecb
to
1399239
Compare
rhoggSugarcrm
force-pushed
the
improve-error-logging
branch
from
1399239
to
a3dd122
Compare
|
Low priority, so moving to Beta 6. |
rhoggSugarcrm
force-pushed
the
improve-error-logging
branch
from
a3dd122
to
b133db4
Compare
khigakisugar
reviewed
Apr 7, 2017
utils.js
Outdated
| * | ||
| * @param {ChakramResponse} response Object to check. | ||
| */ | ||
| assertSaneResponse: function assertSaneResponse(response) { |
There was a problem hiding this comment.
Would we want to also assertSaneResponse for _oauthRequest as well? That doesn't necessarily have to be done in this PR, but it's just something to think about.
There was a problem hiding this comment.
Yes, I should definitely do that!
khigakisugar
approved these changes
Apr 7, 2017
There was a problem hiding this comment.
I approve the changes. I left some comments for @rhoggSugarcrm to review at his convenience, but they do not block the ability to merge this PR.
rhoggSugarcrm
force-pushed
the
improve-error-logging
branch
from
b133db4
to
0d9d75a
Compare
rhoggSugarcrm
commented
Jul 11, 2017
utils.js
Outdated
| */ | ||
| assertSaneResponse: function assertSaneResponse(response) { | ||
| if (!response) { | ||
| throw new Error('Undefined response received!'); |
There was a problem hiding this comment.
I actually need to change this, I shouldn't say something is undefined if it could be some other falsy value.
rhoggSugarcrm
force-pushed
the
improve-error-logging
branch
from
0d9d75a
to
5e25fed
Compare
rhoggSugarcrm
force-pushed
the
improve-error-logging
branch
from
5e25fed
to
7a36bd8
Compare
rhoggSugarcrm
force-pushed
the
improve-error-logging
branch
from
7a36bd8
to
75811e1
Compare
rhoggSugarcrm
force-pushed
the
improve-error-logging
branch
from
75811e1
to
c942303
Compare
rhoggSugarcrm
force-pushed
the
improve-error-logging
branch
from
c942303
to
9dbb988
Compare
rhoggSugarcrm
force-pushed
the
improve-error-logging
branch
from
9dbb988
to
3eac4e6
Compare
rhoggSugarcrm
force-pushed
the
improve-error-logging
branch
from
3eac4e6
to
63e457b
Compare
rhoggSugarcrm
force-pushed
the
improve-error-logging
branch
from
63e457b
to
357e0a9
Compare
rhoggSugarcrm
force-pushed
the
improve-error-logging
branch
from
357e0a9
to
8593650
Compare
jcsmorais
reviewed
Sep 19, 2017
tests/utils.js
Outdated
| @@ -107,6 +107,20 @@ describe('Utils', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| describe('assertSaneResponse', () => { | |||
| it('should throw on falsy response', () => { | |||
There was a problem hiding this comment.
Can we keep the same naming pattern as in other test cases, namely: it should thrown an error ... ?
jcsmorais
reviewed
Sep 19, 2017
tests/utils.js
Outdated
| expect(() => { utils.assertSaneResponse(undefined); }).to.throw('Falsy response received!'); | ||
| }); | ||
|
|
||
| it('should throw if response.response does not exist', () => { |
jcsmorais
reviewed
Sep 19, 2017
utils.js
Outdated
| @@ -21,6 +21,21 @@ let chakram = require('chakram'); | |||
| */ | |||
| let utils = { | |||
| /** | |||
| * Ensure that a Chakram response object is sane before using it. | |||
| * Throws if the response is unreasonable. | |||
jcsmorais
approved these changes
Sep 19, 2017
Signed-off-by: Bob Wombat Hogg <rhogg@sugarcrm.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same as #109, but migrated to my new fork.