This repository has been archived by the owner on Feb 23, 2019. It is now read-only.
metadata-handler: Handle single-number precisions #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhoggSugarcrm
force-pushed
the
handle-single-digit-precisons
branch
from
787b2e7
to
320578b
Compare
rhoggSugarcrm
commented
Mar 21, 2017
metadata-handler.js
Outdated
| if (afterDecimal > 0) { | ||
| val += `.${faker.random.number({ max: Math.pow(10, afterDecimal) })}`; | ||
| } | ||
| val = parseFloat(val); |
There was a problem hiding this comment.
Note to self: we should probably switch this to Number.parseFloat.
There was a problem hiding this comment.
I did that; it's #165
rhoggSugarcrm
force-pushed
the
handle-single-digit-precisons
branch
from
320578b
to
2ae60c0
Compare
khigakisugar
approved these changes
Apr 7, 2017
rhoggSugarcrm
force-pushed
the
handle-single-digit-precisons
branch
from
2ae60c0
to
0ad549d
Compare
rhoggSugarcrm
force-pushed
the
handle-single-digit-precisons
branch
from
0ad549d
to
444f367
Compare
rhoggSugarcrm
force-pushed
the
handle-single-digit-precisons
branch
3 times, most recently
from
71bb5bf
to
957d018
Compare
rhoggSugarcrm
force-pushed
the
handle-single-digit-precisons
branch
from
957d018
to
429df1d
Compare
rhoggSugarcrm
force-pushed
the
handle-single-digit-precisons
branch
from
429df1d
to
2a593f3
Compare
rhoggSugarcrm
force-pushed
the
handle-single-digit-precisons
branch
from
2a593f3
to
21fc592
Compare
rhoggSugarcrm
force-pushed
the
handle-single-digit-precisons
branch
from
21fc592
to
b6fc164
Compare
rhoggSugarcrm
force-pushed
the
handle-single-digit-precisons
branch
from
b6fc164
to
9abff4e
Compare
rhoggSugarcrm
force-pushed
the
handle-single-digit-precisons
branch
from
9abff4e
to
752633f
Compare
rhoggSugarcrm
force-pushed
the
handle-single-digit-precisons
branch
2 times, most recently
from
e281edc
to
1ae94c4
Compare
https://msdn.microsoft.com/en-us/library/ms187746.aspx says that the default scale is 0; i.e. that there should be no digits after the decimal point. Arguably, this is a little silly, but specs are specs.
rhoggSugarcrm
force-pushed
the
handle-single-digit-precisons
branch
from
1ae94c4
to
29d7f0c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://msdn.microsoft.com/en-us/library/ms187746.aspx says that
the default scale is 0; i.e. that there should be no digits after the
decimal point.