This repository has been archived by the owner on Feb 23, 2019. It is now read-only.
Update installation instructions #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhoggSugarcrm
commented
Jul 24, 2017
|
|
||
| You will need to invoke Mocha in order to run Thorn. Check out | ||
| [Mocha's usage information][mocha-usage], [grunt-mocha], and | ||
| [gulp-spawn-mocha] for information about instantiating Mocha. |
There was a problem hiding this comment.
I'm not providing Sugar-specific information here, just a general comment about how to invoke Thorn tests.
jcsmorais
reviewed
Jul 26, 2017
README.md
Outdated
| @@ -2,12 +2,6 @@ | |||
|
|
|||
| Thorn is composed of a set of helper abstractions built to ease the process of setting up a [SugarCRM](https://www.sugarcrm.com) instance's REST API testing environment and interacting with it. | |||
|
|
|||
| ## Installation | |||
There was a problem hiding this comment.
@rhoggSugarcrm why not keeping at least a reference to installation steps here?
There was a problem hiding this comment.
TBH, it makes sense to put it back. I think I was considering being more explicit about how Sugar uses Thorn internally when I originally took this out.
rhoggSugarcrm
force-pushed
the
update-installation-instructions
branch
2 times, most recently
from
8d80b7f
to
6ac70bd
Compare
rhoggSugarcrm
force-pushed
the
update-installation-instructions
branch
from
6ac70bd
to
626c7f4
Compare
rhoggSugarcrm
force-pushed
the
update-installation-instructions
branch
from
626c7f4
to
8fd1fec
Compare
Signed-off-by: Bob Wombat Hogg <rhogg@sugarcrm.com>
Signed-off-by: Bob Wombat Hogg <rhogg@sugarcrm.com>
rhoggSugarcrm
force-pushed
the
update-installation-instructions
branch
from
8fd1fec
to
2aad34b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it clearer that Thorn is meant to be used with Mocha.