Skip to content
This repository has been archived by the owner on Feb 23, 2019. It is now read-only.

index.js: Use JSON.stringify in fixtures error messages #196

Conversation

rhoggSugarcrm
Copy link
Contributor

@rhoggSugarcrm rhoggSugarcrm commented Aug 18, 2017

The error messages currently use toString, which just
displays [object Object] - hardly useful for figuring out
what's wrong with your model/link.

Signed-off-by: Bob Wombat Hogg rhogg@sugarcrm.com

@rhoggSugarcrm rhoggSugarcrm self-assigned this Aug 18, 2017
@rhoggSugarcrm rhoggSugarcrm force-pushed the json-stringify-fixtures-error-messages branch from 5f0dfe7 to b5d38b3 Compare August 21, 2017 18:34
@rhoggSugarcrm rhoggSugarcrm force-pushed the json-stringify-fixtures-error-messages branch from b5d38b3 to 6adcba5 Compare August 30, 2017 19:06
@sugarcrm sugarcrm deleted a comment from coveralls Aug 30, 2017
@sugarcrm sugarcrm deleted a comment from coveralls Aug 30, 2017
@rhoggSugarcrm rhoggSugarcrm force-pushed the json-stringify-fixtures-error-messages branch from 6adcba5 to 1bda9a5 Compare September 5, 2017 16:44
@sugarcrm sugarcrm deleted a comment from coveralls Sep 5, 2017
@rhoggSugarcrm rhoggSugarcrm force-pushed the json-stringify-fixtures-error-messages branch from 1bda9a5 to d34328a Compare September 19, 2017 00:58
@sugarcrm sugarcrm deleted a comment from coveralls Sep 19, 2017
The error messages currently use toString, which just
displays [object Object] - hardly useful for figuring out
what's wrong with your model/link.

Signed-off-by: Bob Wombat Hogg <rhogg@sugarcrm.com>
@rhoggSugarcrm rhoggSugarcrm force-pushed the json-stringify-fixtures-error-messages branch from d34328a to a8a2b90 Compare September 27, 2017 18:33
@coveralls
Copy link

coveralls commented Sep 27, 2017

Coverage Status

Coverage remained the same at 95.549% when pulling a8a2b90 on rhoggSugarcrm:json-stringify-fixtures-error-messages into ecbcd35 on sugarcrm:master.

Copy link
Contributor

@jcsmorais jcsmorais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jcsmorais jcsmorais merged commit 37234b8 into sugarcrm:master Sep 27, 2017
@rhoggSugarcrm rhoggSugarcrm deleted the json-stringify-fixtures-error-messages branch September 27, 2017 20:41
@sugarcrm sugarcrm deleted a comment from coveralls Sep 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants