This repository has been archived by the owner on Feb 23, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhoggSugarcrm
force-pushed
the
validate-params
branch
2 times, most recently
from
August 31, 2017 17:21
bd3d3da
to
4121f23
Compare
rhoggSugarcrm
force-pushed
the
validate-params
branch
from
September 5, 2017 16:47
4121f23
to
7d8bb45
Compare
rhoggSugarcrm
force-pushed
the
validate-params
branch
from
September 19, 2017 00:59
7d8bb45
to
4843a03
Compare
rhoggSugarcrm
force-pushed
the
validate-params
branch
from
September 27, 2017 18:37
4843a03
to
7bc7359
Compare
jcsmorais
reviewed
Sep 27, 2017
index.js
Outdated
@@ -559,6 +561,35 @@ class UserAgent { | |||
}; | |||
|
|||
/** | |||
* Validate request parameters. | |||
* Throws if any of the parameters are invalid. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Throws an error if...
?
This should prevent some common (and anticipated) user errors.
Signed-off-by: Bob Wombat Hogg <rhogg@sugarcrm.com>
rhoggSugarcrm
force-pushed
the
validate-params
branch
from
September 27, 2017 19:40
7bc7359
to
604ab22
Compare
jcsmorais
approved these changes
Sep 27, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should prevent some common (and anticipated) user errors.
Closes #193, but also covers other cases.