Skip to content
This repository has been archived by the owner on Feb 23, 2019. It is now read-only.

Validate request parameters #200

Merged
merged 2 commits into from
Sep 27, 2017
Merged

Conversation

rhoggSugarcrm
Copy link
Contributor

This should prevent some common (and anticipated) user errors.

Closes #193, but also covers other cases.

@coveralls
Copy link

coveralls commented Sep 27, 2017

Coverage Status

Coverage increased (+0.1%) to 95.652% when pulling 7bc7359 on rhoggSugarcrm:validate-params into ecbcd35 on sugarcrm:master.

index.js Outdated
@@ -559,6 +561,35 @@ class UserAgent {
};

/**
* Validate request parameters.
* Throws if any of the parameters are invalid.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Throws an error if...?

This should prevent some common (and anticipated) user errors.
Signed-off-by: Bob Wombat Hogg <rhogg@sugarcrm.com>
@coveralls
Copy link

coveralls commented Sep 27, 2017

Coverage Status

Coverage increased (+0.1%) to 95.652% when pulling 604ab22 on rhoggSugarcrm:validate-params into 2cde8a2 on sugarcrm:master.

Copy link
Contributor

@jcsmorais jcsmorais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jcsmorais jcsmorais merged commit 782b4a4 into sugarcrm:master Sep 27, 2017
@rhoggSugarcrm rhoggSugarcrm deleted the validate-params branch September 27, 2017 20:43
@sugarcrm sugarcrm deleted a comment from coveralls Sep 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants