Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to Python 3 #10

Merged
merged 2 commits into from
Aug 24, 2019
Merged

Port to Python 3 #10

merged 2 commits into from
Aug 24, 2019

Conversation

Aniket21mathur
Copy link
Contributor

Tested with toolkit-gtk3 v0.114.

@quozl
Copy link

quozl commented Jun 10, 2019

Thanks for 940233b. Comments;

  • you've done flake8 changes mixed with other changes; this make reviewing much harder, please try to do these in a different pull request next time,
  • when wrapping argument lists, please do it intelligently, allowing more than one argument per line, as the style you've chosen unnecessarily consumes lines, (limits comprehension of source code when a new developer reads the code in an editor).
  • you've done only some flake8 changes; python3 -m flake8 . still gives 3 hits.

@Aniket21mathur Aniket21mathur added this to Pull Requests in Port to Python 3 via Six Jul 18, 2019
@quozl quozl merged commit d198c35 into sugarlabs:master Aug 24, 2019
@Dimi20cen Dimi20cen mentioned this pull request Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants