Bad file for binary mode icon

[rhl-bthr]

Steps to reproduce:

• Open the activity

Logs have this:

1523625981.252962 ERROR root: Exception reading icon info: File contains no section headers.
file: /usr/share/icons/gnome/48x48/mimetypes/binary.png, line: 1
'\x89PNG\r\n'
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/sugar3/graphics/icon.py", line 214, in _get_attach_points
    cp.readfp(config_file)
  File "/usr/lib/python2.7/ConfigParser.py", line 324, in readfp
    self._read(fp, filename)
  File "/usr/lib/python2.7/ConfigParser.py", line 512, in _read
    raise MissingSectionHeaderError(fpname, lineno, line)
MissingSectionHeaderError: File contains no section headers.
file: /usr/share/icons/gnome/48x48/mimetypes/binary.png, line: 1
'\x89PNG\r\n'

[rhl-bthr]

Reproduced on:
Ubuntu 16.04, Sugar 0.112 using Abacus at c0f998e

[quozl]

Does not occur if the gnome-icon-theme package is not installed.

Looks like a problem in the toolkit, caused by a GNOME icon having same first-name as an Abacus icon. There's probably nothing wrong with Abacus using this same icon name.

• sugarlabs/sugar-toolkit-gtk3@f796638
• https://github.com/sugarlabs/sugar-toolkit-gtk3/blob/master/src/sugar3/graphics/icon.py#L196

Perhaps add a check for '.svg' in info.get_filename() before replacing it?

[walterbender]

We could rename the icon in any case.

[quozl]

As it has no impact in the activity, I don't think it is worth renaming. I've added a toolkit fix.