Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding A Suitable License #1

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@pipix51
Copy link

pipix51 commented Dec 7, 2017

As Sugar Labs is migrating to a new activity server, activity repositories such as this now require a separate file for the license. Based on your .py files, it seems that the license is GPL version 2, which I have added as a separate file in this pull request. Please merge this pull request. Thank you!

@yashagrawal3

This comment has been minimized.

Copy link
Member

yashagrawal3 commented May 20, 2018

@quozl we just need to add a copying file, so this can be merged.

@tony37

This comment has been minimized.

Copy link

tony37 commented May 20, 2018

@yashagrawal3

This comment has been minimized.

Copy link
Member

yashagrawal3 commented May 20, 2018

@tony37 OK!

@quozl

This comment has been minimized.

Copy link

quozl commented May 21, 2018

@yashagrawal3, you might defer this activity to later in your list, because it will be a huge time sink. This activity needs much more than a COPYING file. It needs;

  • restoring the git history lost when @tony37 created the repository from a bundle instead of using http://git.sugarlabs.org/ceibal-chess or https://github.com/alesegovia/ceibal-chess
  • add license metadata in activity.info (which can be found in @alesegovia's repository), along with a license for the embedded binary,
  • removing the MANIFEST file,
  • updating the embedded binary to the latest version and including other architectures; or adding a dependency that must be resolved before installing the activity.
  • perhaps merging translations from the SimpleGNUChess activity on https://translate.sugarlabs.org
  • testing,
  • porting to GTK+ 3,
  • testing,
  • release.

@alesegovia may have some ideas on how to proceed.

@tony37

This comment has been minimized.

Copy link

tony37 commented May 21, 2018

@quozl

This comment has been minimized.

Copy link

quozl commented May 21, 2018

There were two repositories. You destroyed, by ignoring, commits to those repositories. You've done it several times now; but I'm not surprised, as you aren't an activity maintainer yet.

GTK+ is the name to the toolkit according to both The GTK+ Project and Wikipedia. It deserves a "+" because that's the name the authors used. I'll continue to credit their work by using the proper name.

The list of tasks for an activity maintainer is in
https://github.com/sugarlabs/sugar-docs/blob/master/src/contributing.md#checklist---maintainer
and already includes incrementing a version number.

Translations should be merged to honour the work done by translators; it is the same activity, based on recursive comparison of files.

I don't plan to make this activity available for "Ubuntu Sugar", because it is in terrible shape. If someone were to maintain it, then I'd be a bit more interested.

@pro-panda

This comment has been minimized.

Copy link
Member

pro-panda commented Jan 17, 2019

Stale.

@pro-panda pro-panda closed this Jan 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.