Upstreaming v9 #14
Upstreaming v9 #14
Conversation
Possibly these were an intention to implement game pause on alt-tab.
Variable is not used anywhere else, so remove it.
No reason to force the title, as it is forced already by BlockParty.
Same font is used for more than score, so stop calling it a scorefont.
Clutter of logs, and did not add any value
Method has no caller.
A port to GTK 3 should have changed the expose callback to a draw callback, using the supplied cairo.Context. Possibly reduces display update CPU cost. Regression introduced 6af29a1
Port to GTK 3 did not complete all porting. Now possible again to run the game using "python3 BlockParty.py"
Vanishing cursor helps to avoid distraction, but it was lost in the port to GTK 3. Get the saved cursor from the window after it is realized. Flush the cursor change through Gdk. Keep the timer source identifier. When the activity is closing, stop the timer and audio player, otherwise the timer may trigger and VanishingCursor may try to restore the cursor while there is no window for the Gtk.DrawingArea, yielding traceback.
Sugar has a configuration setting for font face and size, so use it rather than a pre-coded face and size. Also scale according to display size relative to the 900 pixel width of the OLPC XO-1.
We're odd, because we draw on Gtk.Window. Makes it impossible to add a Sugar toolbar. Instead, let's draw on the new Gtk.DrawingArea widget.
Also avoid dropping unhandled key press events (return True), as it prevented the ctrl+q stop accelerator from working.
Adjust height by the expected size of the toolbar.
Icon is the "T" tetronimo, upside down, with extra gap between the squares. Squares in the icon were not distributed evenly across the available dimensions, and the shape centre was above and to the right of the icon centre.
|
I don't have rights to change master yet. But you can see your changes in my Python 2 branch underneath my changes, and in the master branch. So I think what you ask is already done. |
|
Yes, thankyou :) |
|
Reviewed, thanks. I think that since an activity toolbar has been added, the use of the escape key to quit the game should be changed to pause the game because sometimes one might decide to pause the game and not want to quit it when pressing the escape key and I've pressed it thinking it'll pause it quite a number of times. |
|
Thanks. I don't agree to change the escape key because users have already learned what it does, so an update would frustrate them. I have no idea how you came to the conclusion that the escape key would pause the game, given that the words "Press ESC to exit" are shown. |
|
Regarding adding a pause button: I don't think we should add one because then the child can pause the game, think where to place the upcoming block and again resume. This gives the child more time to think than needed and defeats the purpose of the activity: quick thinking for block rotation and placement. |
|
I don't think anyone is adding a pause button. |
|
Agreed, I'd looked at it from a different perspective earlier. |
Some changes in the Python 2 branch are potentially useful for the Python 3 branch.