Add feature: Show Ghost piece #33
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This feature allows player to see where their piece is going to land - Only py is calculated for ghost piece as px remains the same - It is done through generate_ghost_py() which checks where the peice can be dropped, and return that py - The color for the ghost pieces are generated by interpolating the original tile color and the background tile color through the function get_ghost_color()
Gdk.color_parse is deprecated in Gdk4.0 so we don't need to use it anymore Signed-off-by: Chihurumnaya Ibiam <ibiam@sugarlabs.org>
Signed-off-by: Chihurumnaya Ibiam <ibiam@sugarlabs.org>
|
Reviewed, added some commits. Please review. Also noticed that the key up event isn't handle sometimes, moving the block to the left or right then trying it makes it work and I haven't taken a look but it's possible it also happens on master. |
chimosky
reviewed
Jun 11, 2023
|
Reviewed, and I have made the necessary changes for getting the color through gdk.rgba |
- Now this functionality is replaced with a for loop and it copies the colors from the self.colors array which already contains parsed colors
chimosky
reviewed
Jun 11, 2023
|
Tested f89dd40, works as expected. I'll wait for others to test and review. |
|
reviewed and tested, working fine. |
|
Great! Merged by hand, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
please review @chimosky @sourabhaa