Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port from GConf to Gio.Settings using staged release #79

Merged
merged 8 commits into from
Apr 2, 2018

Conversation

quozl
Copy link
Contributor

@quozl quozl commented Mar 26, 2018

Port from GConf to Gio.Settings using staged release.

Browse uses three settings;

  • backup-url, part of Sugar, maintained by Sugar 0.112 in GConf and Gio.Settings,
  • jabber-server, part of Sugar, maintained by Sugar 0.112 in GConf and Gio.Settings,
  • home-page, private to Browse only.

Staged release plan;

  • v201.5 is to store home-page in an activity specific Gio.SettingsSchemaSource, and compile the schema on first start,
  • v202 is to drop GConf support.

Branch also contains release tags.

Tested on Ubuntu 16.04.

@quozl quozl force-pushed the 2018-03-26-no-gconf branch 2 times, most recently from ee725c9 to 5336130 Compare March 28, 2018 07:05
@quozl quozl changed the title In progress - Port from GConf to Gio.Settings Port from GConf to Gio.Settings Mar 28, 2018
"activity" was used as both a module name and an argument.

Import the module method directly so as to avoid the dual use.
For home-page setting, use an activity-specific
Gio.SettingsSchemaSource, compile the schema on first start, and store
the changed value in the Gio.Settings as well as in GConf.
New strings from 1ea8e0a ("Detect and avoid Fedora 18 systems").
Browse used GConf to read or store settings, and as of v201.5 also used
Gio.Settings to redundantly store home-page setting.

GConf is no longer available.

- remove GConf,

- rely on Gio.Settings instead.
@quozl quozl changed the title Port from GConf to Gio.Settings Port from GConf to Gio.Settings using staged release Mar 29, 2018
Copy link
Contributor

@rhl-bthr rhl-bthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

Reviewed and tested.

Copy link

@yell0wfl4sh yell0wfl4sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and tested.

Tested on: Ubuntu 17.10

@quozl quozl merged commit 05c49fa into sugarlabs:master Apr 2, 2018
@quozl quozl deleted the 2018-03-26-no-gconf branch April 2, 2018 00:16
@quozl quozl moved this from Relevant to Done in Port from GConf to Gio.Settings Apr 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants