-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port from GConf to Gio.Settings using staged release #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ee725c9
to
5336130
Compare
"activity" was used as both a module name and an argument. Import the module method directly so as to avoid the dual use.
For home-page setting, use an activity-specific Gio.SettingsSchemaSource, compile the schema on first start, and store the changed value in the Gio.Settings as well as in GConf.
5336130
to
73aaa12
Compare
New strings from 1ea8e0a ("Detect and avoid Fedora 18 systems").
Browse used GConf to read or store settings, and as of v201.5 also used Gio.Settings to redundantly store home-page setting. GConf is no longer available. - remove GConf, - rely on Gio.Settings instead.
73aaa12
to
6e077a5
Compare
rhl-bthr
approved these changes
Mar 29, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
Reviewed and tested.
yell0wfl4sh
approved these changes
Mar 29, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed and tested.
Tested on: Ubuntu 17.10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port from GConf to Gio.Settings using staged release.
Browse uses three settings;
backup-url
, part of Sugar, maintained by Sugar 0.112 in GConf and Gio.Settings,jabber-server
, part of Sugar, maintained by Sugar 0.112 in GConf and Gio.Settings,home-page
, private to Browse only.Staged release plan;
home-page
in an activity specific Gio.SettingsSchemaSource, and compile the schema on first start,Branch also contains release tags.
Tested on Ubuntu 16.04.