Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete activity bundle after download and install #81

Open
quozl opened this Issue May 7, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@quozl
Copy link
Contributor

quozl commented May 7, 2018

Reproducer:

  • download an activity bundle from activities.sugarlabs.org or wiki.laptop.org,

Observed result:

  • activity bundle is both installed and left in journal

Expected result:

  • activity bundle is installed and not left in journal.
@Hrishi1999

This comment has been minimized.

Copy link

Hrishi1999 commented Jan 24, 2019

Sorry if I am wrong, but shouldn't this be a journal feature?
At https://github.com/sugarlabs/sugar/blob/489974f4243eb3a18c0bea07812c436ed8aa7d5c/src/jarabe/view/customizebundle.py , generate_bundle is what installs the activity right? So it should be implemented there?

@quozl

This comment has been minimized.

Copy link
Contributor Author

quozl commented Jan 24, 2019

Good question. I've other questions to suggest; How did Browse trigger it? Why does Browse not receive an answer? Why does Browse not delete the journal object afterwards?

@Hrishi1999

This comment has been minimized.

@quozl

This comment has been minimized.

Copy link
Contributor Author

quozl commented Jan 26, 2019

Don't think so, that just writes the bundle to the journal. Wouldn't it be the callback to the prompt? See https://github.com/sugarlabs/browse-activity/blob/master/downloadmanager.py#L301 and try commenting that line out, you may find it won't install the bundle? You can find launch_bundle in the Sugar Toolkit. It does return something, but I'm not sure how to be sure when it is finished installing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.