Dev #18
Merged
Dev #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. Tested. Please put traceback from first pull request comment into commit message of patch that fixes it? |
Saumya-Mishra9129
approved these changes
Jul 12, 2020
|
Re: dabbb80 the traceback has lost indentation; the usual cognitive process that processes the traceback is challenged or reduced by the change to indentation. |
Fix: IndexError.
Traceback (most recent call last):
File "/usr/share/sugar/activities/dotsAndBoxes.activity/main.py", line 366, in run
ret = self.where(pos)
File "/usr/share/sugar/activities/dotsAndBoxes.activity/main.py", line 211, in where
b = self.boxes[x_b][y_b]
IndexError: list index out of range
To reproduce- Play a game half way and change V or H values, then try playing with changed grid. IndexError seen.
|
@quozl done |
|
Thanks. Reviewed. Approved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit 11706fc Fixes Changing the H and V values to 2 mess up the lines #16
Fix IndexError
Traceback (most recent call last):
File "/usr/share/sugar/activities/dotsAndBoxes.activity/main.py", line 366, in run
ret = self.where(pos)
File "/usr/share/sugar/activities/dotsAndBoxes.activity/main.py", line 211, in where
b = self.boxes[x_b][y_b]
IndexError: list index out of range
Seen when H and V values are changed mid game. The fix seems small but took me time to figure out the cause. Initially I thught it was a port to python3 regression but wasn't.
@quozl @chimosky Please test, review and merge :)