Unify and translate conozco.py to en.US

[srevinsaju]

• Translate Espanol to English
• Reorder imports
• Flake8 Fixes
• Correct DBus.LookupError
• Normal termination of activity

I am planning to copy paste this commit on every conozco activity on sugarlabs.
Please check if it is right

[srevinsaju]

@quozl @chimosky Please review, however after this commit there are few advantages and disadvantages

Advantages

• The DBusLookupError of all the activities will get fixed, because the same conozco.py will be replicated in other iknow* actvities
• All the Espanol terms get translated to English
• More whitespace and flake8 fixes
• Normal termination of activities

Disadvantages

• A git bisect might not be possible after the commit / or to find errors related to the same

---

Is it possible to maintain a single copy of conozco.py in another repository, so that it remains a unique file, similar to sugargame on sugarlabs/sugargame or, collabwrapper on sugarlabs/collabwrapper. This might help future contributors to fix and release bugs on all the iknow* activities by releasing and tagging conozco on the main repository

This is a suggesstion, please let me know of the possibility.

---

This PR needs to be tested extensively before its deployed on all the iknow* activities.

[quozl]

I'm fine with a complete change in principle. I think it is too large to review, and best path forward may be to increase the number of people testing. I'd rather not have yet another repository. 😁

[srevinsaju]

@quozl Yes, it was complete rewrite of variable names as such. Feel free to close this PR, in case if its not necessary at the moment; If you would like me to replicate the same conozco.py in every iknow* activities, I could do that too so that all the activities which have diverged from the main conozco can receive all the bugfixes which each iknow* activity recieved on sugarlabs

[chimosky]

Use importlib as imp existed in python2 and no longer does.

[quozl]

python3 -c "import imp" seems to work for me on 3.6.9. Is there a specific version where it does not work?

[chimosky]

Using 3.7.3 importing it throws a DeprecationWarning.

[quozl]

Thanks. A fix is in

https://github.com/sugarlabs/iknowEditor/blob/master/conozco.py#L31-L32

https://github.com/sugarlabs/iknowEditor/blob/master/conozco.py#L251

Seems a lot of work to go through just to keep the file in a non-module directory, otherwise a plain import would be fine. I wonder what was behind this design decision?

[srevinsaju]

Thanks, I will update accordingly

[chimosky]

I'm fine with a complete change in principle. I think it is too large to review, and best path forward may be to increase the number of people testing. I'd rather not have yet another repository. grin

I agree, I haven't reviewed yet; just took a look.

[quozl]

@quozl Yes, it was complete rewrite of variable names as such. Feel free to close this PR, in case if its not necessary at the moment;

No need to close, it's better than what we have now.

If you would like me to replicate the same conozco.py in every iknow* activities, I could do that too so that all the activities which have diverged from the main conozco can receive all the bugfixes which each iknow* activity recieved on sugarlabs

You're welcome to do that, just that these should be considered as wide-ranging changes and won't necessarily get a detailed review. The activities are local, so a smaller user base. The iKnow Editor is the most important one to get right, and the generated code should look like that.

[srevinsaju]

I tried to update the iknowEditor with a updated version of conozco, but as iknowEditor was not in a working condition in the first place, so I did not update it. The save function in the iknowEditor does not work at the moment or I have no clue where the file is saved.

[quozl]

Well, that's news to me too. No issues created or fixes proposed. You could debug the save function with pdb?

[srevinsaju]

Sure, then I shall fix iknowEditor before other iknow* activities.

[srevinsaju]

Wow!, The iknowEditor 's conozco did not load the imported module. I was trying to figure out why the patched conozco from iknowEditor did not load the imported module, and thats probably why it did not work